Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace stream.value() with stream for stream_view args #7236

Merged
merged 3 commits into from
Feb 4, 2021
Merged

Replace stream.value() with stream for stream_view args #7236

merged 3 commits into from
Feb 4, 2021

Conversation

karthikeyann
Copy link
Contributor

No description provided.

@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 28, 2021
@karthikeyann karthikeyann requested a review from a team as a code owner January 28, 2021 10:34
rgsl888prabhu
rgsl888prabhu approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would need copyright update.

@karthikeyann
Copy link
Contributor Author

Would need copyright update.

One liner to update copyright year in all changed files in PR (needs github cli)

gh pr diff | grep -F "+++ b/" | sed "s#+++ b/##g"  | xargs -L1 sed -i -E "s/Copyright *\(c\) *([0-9,-]+)*-([0-9]{4}), *NVIDIA *CORPORATION/Copyright (c) \\1-`date +%Y`, NVIDIA CORPORATION/; /`date +%Y`/! s/Copyright *\(c\) ([0-9]{4}), *NVIDIA *CORPORATION/Copyright (c) \\1-`date +%Y`, NVIDIA CORPORATION/" $1

@karthikeyann karthikeyann added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Feb 4, 2021
@karthikeyann
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Feb 4, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.19@2b8de0e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.19    #7236   +/-   ##
==============================================
  Coverage               ?   82.21%           
==============================================
  Files                  ?      100           
  Lines                  ?    16955           
  Branches               ?        0           
==============================================
  Hits                   ?    13939           
  Misses                 ?     3016           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b8de0e...7c88a50. Read the comment docs.

@kkraus14
Copy link
Collaborator

kkraus14 commented Feb 4, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 62d2643 into rapidsai:branch-0.19 Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

@devavret devavret devavret approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karthikeyann @kkraus14 @devavret @rgsl888prabhu